Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Verify current version of ASM being used by stable and edge JRuby

Currently the version of ASM bundled in Clojure is pretty old (circa 2005).  There are some documented performance improvements in newer versions of ASM that should speed up some things in Clojure.

Next Steps

...

We would like to move to the latest stable version of ASM (4.1); the current Clojure code uses 3.3.1

...

Future Steps

  • Build an independent (but still re-rooted) clojure.asm jar, and a dep on it. That way delivery targets that don't use dynamic code gen (e.g. Android) can easily leave it out.

.  

Release notes for ASM 4.0 and 4.1.

It may not be the desired approach, but CLJ-713 has a patch related to this.

Open Questions to Resolve

Some open questions:

  1. Should we use ASM jar as is (make the dependency public) or use re-rooted versions that cannot conflict?
    1. Scala: 2.10+ uses ASM 4.1, subsetted, and rerooted to scala.tools.asm
    2. Groovy: 2.1 (latest stable) uses ASM 4.0 external, 2.2 (next) uses ASM 4.1 external
    3. JRuby: 1.7.4 (latest stable) uses ASM 4.0, subsetted, and rerooted to org.jruby.org.objectweb.asm. According to Charles Nutter 1.7.x will stay on 4.0. As of Feb. 19, 2014 the version on master has been bumped to 4.2 as 5.0 is currently in beta.
    4. Recommend:  re-root to avoid conflicts
  2. What (if anything) needs to be done with computing stack frames to satisfy bytecode verification changes in JDK 7?
    1. Recommend: 
  3. If re-rooted, should we subset the jar and only include what we use rather than the whole jar?
    1. Recommend: yes, as long as we're modifying we might as well subset
  4. If using a re-rooted jar, should we provide a split version of the re-rooted asm to allow it to be optional for environments that don't need it?
    1. Recommend:

 

Next Steps

Future Steps