Error formatting macro: pagetree: java.lang.NullPointerException
Skip to end of metadata
Go to start of metadata
You are viewing an old version of this page. View the current version. Compare with Current  |   View Page History

In the past, I've suggested using a custom workflow in JIRA to make it easier for everyone involved to follow and understand the contribution process.  That's always languished, but the cumulative pain I was seeing prompted me to speak up again about it at the /dev meetup at the Conj on Saturday.

I've created a custom workflow that attempts to formalize my understanding of the contribution process (based on this for the most part), and attached it to a dummy project in JIRA.  The result is what I think is what would be a less confusing experience for everyone involved, with useful actions ('submit for screening', 'reject patch', 'change approved', etc) being elevated to workflow transitions rather than being represented by multiple edits involving custom fields in addition to default workflow transitions.

I started with the default JIRA workflow, and added two new states:

  • Ready for screening
  • Screened

…with transitions to/from these states to the default JIRA workflow states (e.g. Open -> Ready, In Progress -> Ready, Screened -> Open, Screened -> Closed, etc).  You can see the net effect here:

http://dev.clojure.org/jira/plugins/servlet/project-config/IGNOREJIRAEXP/workflows

I take no credit nor blame for the entirely shoddy presentation of state diagram that JIRA generates — click the graph-esque icon on the right of that page to see the current version of it. (Admin access required; a screenshot of the current draft workflow, and below that a hand-created figure that should be identical to the screenshot, but easier to follow



I've tested this with a dummy issue (http://dev.clojure.org/jira/browse/IGNOREJIRAEXP-1) and I believe this now makes concrete most of workflow described and diagrammed on the wiki.  Feel free to abuse that issue, create others, and see how workflow feels.

Things that don't map well at the moment:

  • Various states of the Patch and Approval fields.  There are no separate workflow states depending on whether a patch contains just code or code+tests (a good thing, IMO).  The draft workflow represents the other states of Patch explicitly.  I think the same goes for the Accepted field; the most important one there ("incomplete") corresponds to an explicit "Reject patch" transition that automatically asks for a comment to be added to the issue.
  • The process of "vetting" (i.e. bucketing into a backlog vs. fast-tracked to Release.next based on importance), and the state change that goes along with it.  That can be added as a separate state in the workflow, but I haven't gotten to it so far.
  • There's currently no way to restrict a transition to the project lead, i.e. only Rich being able to "OK" a patch (or, a contrib project lead saying "OK", though modeling that case seems like a non-issue at the moment).  Right now, approving a patch or closing or resolving an issue after an approved patch has been applied can only be done by "Project administrators", which includes all members of jira-administrators *and* the current project lead.  Certainly not the right permissions, but more accurate than the current policy around the Approval field (diligently guarded by a "Core team only, please" label ;-)

A final note: it would be good if most of the content of http://clojure.org/patches were replaced en masse with a link to http://dev.clojure.org/display/design/JIRA+workflow — "even" I went to the former first (having forgotten about the latter), which is decidedly out of date AFAICT.

Labels: