The job of screening is to create a funnel, so that the highest importance, highest urgency items are brought to the BDFL's attention first, already vetted and tested.

Choosing Tickets to Screen

  1. Bugs first, then features. Most users do not edit the issue type or severity fields, so most tickets start marked as bugs, and job 1 is to recategorize them.
  2. Focus on tickets with code. If there isn't code yet, you will have to write it, and have someone else screen it.
  3. No new features during Beta. The most a feature request can hope for during Beta is to be assigned the "Approved Backlog" release
  4. Do the important bugs first. There is no AI query to find these. One obvious criterion for importance is difficulty of workaround. Another is regression. Another is upvoted issues.
  5. Vote up issues you think important.

Fail Fast

Bounce bad tickets as quickly as possible.

  1. Tickets are supposed to begin with a discussion, typically on clojure-dev, clojure, the dev wiki, or IRC. Don't sweat this for trivial things like doc spelling fixes, but for anything non-trivial, please mark the ticket as incomplete and request a link to the discussion.
  2. Decline tickets that do too many things (Too many is usually "more than one."), and ask the submitter to resubmit smaller patches.
  3. Decline feature enhancements that could begin life as a library instead. Be encouraging and redirect the person to an appropriate Contrib (or propose a new Contrib).
  4. Decline tickets that are poor style. But remember that Library Coding Standards are guidelines, not fixed laws of the Universe.
  5. Decline tickets that do not seem comprehensive. 

Want to Become a Screener?

Screeners are a subset of contributors who are responsible for moving tickets through a review process, and then funneling tickets to the BDFL.

It would be great to have more screeners. If you are interested, just do all the steps described in this document, without actually changing any ticket attributes. Instead, add a comment to the ticket explaining what you would have done to screen it. (Screeners: keep an eye out for such comments, and where sensible provide feedback so that we are grooming more screeners.)

Process in Detail

Periodically, screeners will review tickets whose approval is marked 'Test'.

To apply someone's changes you need to first create a branch:

$ git checkout -b freds_fixbug42
$ git am --keep-cr -s --ignore-whitespace < their-patch-file.diff

Once you have a working copy, you should take note of the following kinds of things:

After review, if you are happy, you should

If you are not happy, but the ticket is fixable:

If you are not happy, and the ticket does not seem fixable

If you aren't sure