[#ASYNC-170] binding in go block causes thread binding error: "Pop without matching push" - Clojure JIRA

Details

Type: Defect
Status: In Progress
Priority: Major
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None
Environment:
Clojure 1.8.0, core.async 0.2.374

Patch:
Code and Test
Approval:
Triaged

Description

Reproduced in https://github.com/whilo/async-binding.

(def ^:dynamic *foo* nil)

(defn -main [& args]
  (go
    (binding [*foo* nil]
      (<! (go 42))
      (println "done.")))

  (Thread/sleep 30000))

$ lein uberjar
$ java -jar ...

done.
Exception in thread "async-dispatch-3" java.lang.IllegalStateException: Pop without matching push
	at clojure.lang.Var.popThreadBindings(Var.java:331)
	at clojure.core$pop_thread_bindings.invokeStatic(core.clj:1839)
	at clojure.core$pop_thread_bindings.invoke(core.clj:1839)
	at async_binding.core$_main$fn__6354$state_machine__4495__auto____6355$fn__6357.invoke(core.clj:8)
	at async_binding.core$_main$fn__6354$state_machine__4495__auto____6355.invoke(core.clj:8)
	at clojure.core.async.impl.ioc_macros$run_state_machine.invokeStatic(ioc_macros.clj:1011)
	at clojure.core.async.impl.ioc_macros$run_state_machine.invoke(ioc_macros.clj:1010)
	at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invokeStatic(ioc_macros.clj:1015)
	at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invoke(ioc_macros.clj:1013)
	at clojure.core.async.impl.ioc_macros$take_BANG_$fn__4511.invoke(ioc_macros.clj:1024)
	at clojure.core.async.impl.channels.ManyToManyChannel$fn__313$fn__314.invoke(channels.clj:95)
	at clojure.lang.AFn.run(AFn.java:22)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

0001-ASYNC-170-update-binding-frame-on-loop-exit.patch

20/Sep/16 1:31 AM

5 kB

Kevin Downey

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Kevin Downey added a comment - 27/May/16 1:46 AM

this issue only reproduces when the code is aot compiled

Show

Kevin Downey added a comment - 27/May/16 1:46 AM this issue only reproduces when the code is aot compiled

Nicola Mometto made changes - 27/May/16 6:51 AM

Field	Original Value	New Value
Description	Reproduced in https://github.com/whilo/async-binding. (def ^:dynamic foo nil) (defn -main [& args] (go (binding [foo nil] (<! (go 42)) (println "done."))) (Thread/sleep 30000)) $ lein uberjar $ java -jar ... done. Exception in thread "async-dispatch-3" java.lang.IllegalStateException: Pop without matching push at clojure.lang.Var.popThreadBindings(Var.java:331) at clojure.core$pop_thread_bindings.invokeStatic(core.clj:1839) at clojure.core$pop_thread_bindings.invoke(core.clj:1839) at async_binding.core$_main$fn__6354$state_machine__4495__auto____6355$fn__6357.invoke(core.clj:8) at async_binding.core$_main$fn__6354$state_machine__4495__auto____6355.invoke(core.clj:8) at clojure.core.async.impl.ioc_macros$run_state_machine.invokeStatic(ioc_macros.clj:1011) at clojure.core.async.impl.ioc_macros$run_state_machine.invoke(ioc_macros.clj:1010) at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invokeStatic(ioc_macros.clj:1015) at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invoke(ioc_macros.clj:1013) at clojure.core.async.impl.ioc_macros$take_BANG_$fn__4511.invoke(ioc_macros.clj:1024) at clojure.core.async.impl.channels.ManyToManyChannel$fn__313$fn__314.invoke(channels.clj:95) at clojure.lang.AFn.run(AFn.java:22) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745)	Reproduced in https://github.com/whilo/async-binding. {code} (def ^:dynamic foo nil) (defn -main [& args] (go (binding [foo nil] (<! (go 42)) (println "done."))) (Thread/sleep 30000)) $ lein uberjar $ java -jar ... done. Exception in thread "async-dispatch-3" java.lang.IllegalStateException: Pop without matching push at clojure.lang.Var.popThreadBindings(Var.java:331) at clojure.core$pop_thread_bindings.invokeStatic(core.clj:1839) at clojure.core$pop_thread_bindings.invoke(core.clj:1839) at async_binding.core$_main$fn__6354$state_machine__4495__auto____6355$fn__6357.invoke(core.clj:8) at async_binding.core$_main$fn__6354$state_machine__4495__auto____6355.invoke(core.clj:8) at clojure.core.async.impl.ioc_macros$run_state_machine.invokeStatic(ioc_macros.clj:1011) at clojure.core.async.impl.ioc_macros$run_state_machine.invoke(ioc_macros.clj:1010) at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invokeStatic(ioc_macros.clj:1015) at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invoke(ioc_macros.clj:1013) at clojure.core.async.impl.ioc_macros$take_BANG_$fn__4511.invoke(ioc_macros.clj:1024) at clojure.core.async.impl.channels.ManyToManyChannel$fn__313$fn__314.invoke(channels.clj:95) at clojure.lang.AFn.run(AFn.java:22) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) {code}

Hide

Permalink

Christian Weilbach added a comment - 27/May/16 6:55 AM

Right, I missed to add the AOT condition here, only in the repository. I cannot update the issues myself, right? I tried also to close another issue I opened, but couldn't find a way to close it.

Show

Christian Weilbach added a comment - 27/May/16 6:55 AM Right, I missed to add the AOT condition here, only in the repository. I cannot update the issues myself, right? I tried also to close another issue I opened, but couldn't find a way to close it.

Alex Miller made changes - 17/Jun/16 11:00 AM

Summary	binding in go block causes tread binding error: "Pop without matching push"	binding in go block causes thread binding error: "Pop without matching push"
Approval		Triaged [ 10120 ]

Kevin Downey made changes - 20/Sep/16 1:31 AM

Attachment

0001-ASYNC-170-update-binding-frame-on-loop-exit.patch [ 15954 ]

Kevin Downey made changes - 20/Sep/16 1:31 AM

Patch

Code and Test [ 10002 ]

Kevin Downey made changes - 20/Sep/16 1:34 AM

Assignee

Kevin Downey [ hiredman ]

Kevin Downey made changes - 20/Sep/16 1:35 AM

Status

Open [ 1 ]

In Progress [ 3 ]

Kevin Downey made changes - 09/Aug/17 1:41 PM

Assignee

Kevin Downey [ hiredman ]

Hide

Permalink

Alex Miller added a comment - 09/Aug/17 2:57 PM

Christian Weilbach I've added you to the appropriate groups to allow you to edit tickets.

Show

Alex Miller added a comment - 09/Aug/17 2:57 PM Christian Weilbach I've added you to the appropriate groups to allow you to edit tickets.

People

Assignee:

Unassigned

Reporter:

Christian Weilbach

Vote (1)

Watch (2)

Dates

Created:

26/May/16 1:22 PM

Updated:

09/Aug/17 2:57 PM