Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

(CLJS) excluded bounded-count in use in cljs.core.async

Description

With ASYNC-171, bounded-count was excluded. But, it is actually being used in cljs.core.async/to-chan here:

https://github.com/clojure/core.async/blob/43139e44b04dd09bb5faa555ea8ebd2ca09e25ce/src/main/clojure/cljs/core/async.cljs#L395

It has evidently been in use (inadvertently incorrectly) since 2013 (well prior to it having been added as a core function), with it picking up a previous private definition that had existed in cljs.core all along (but with the arguments reversed, evidently fortuitously without breaking things completely).

Here is a REPL transcript illustrating the regression that ASYNC-171 causes:

ClojureScript Node.js REPL server listening on 52771 To quit, type: :cljs/quit cljs.user=> (require 'cljs.core.async) WARNING: Use of undeclared Var cljs.core.async/bounded-count at line 395 file:/Users/mfikes/Projects/core.async/target/core.async-0.1.0-SNAPSHOT.jar!/cljs/core/async.cljs WARNING: Use of undeclared Var cljs.core.async/bounded-count at line 395 .cljs_node_repl/cljs/core/async.cljs nil cljs.user=> (cljs.core.async/to-chan []) TypeError: Cannot read property 'call' of undefined at cljs$core$async$to_chan (/Users/mfikes/Projects/clojurescript/.cljs_node_repl/cljs/core/async.js:3042:70) at repl:1:113 at repl:9:3 at repl:14:4 at Object.exports.runInThisContext (vm.js:54:17) at Domain.<anonymous> ([stdin]:41:34) at Domain.run (domain.js:221:14) at Socket.<anonymous> ([stdin]:40:25) at emitOne (events.js:77:13) at Socket.emit (events.js:169:7)

You can also presumably see this if you run the ClojureScript core.async unit tests. In particular the cljs.core.async.pipeline-test namespace makes use of to-chan. (I say presumably—I haven't figured out how to run them in JVM ClojureScript, but ran the same in self-hosted ClojureScript and discovered this regression running these unit tests with the fork of core.async for self-hosted ClojureScript here: https://github.com/mfikes/andare

Environment

None

Activity

Show:

Details

Assignee

Reporter

Priority

Created September 7, 2016 at 4:18 AM
Updated February 13, 2017 at 9:39 PM

Flag notifications