core.async

(CLJS) Port ASYNC-169 fixes to cljs

Details

  • Type: Defect Defect
  • Status: In Progress In Progress
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Patch:
    Code and Test
  • Approval:
    Vetted

Description

ASYNC-169 addresses many try/catch/finally in go block issues on the Clojure side and should be ported to cljs side as well.

Activity

Hide
Kevin Downey added a comment -

I am not 100% on how all the clojurescript stuff works, but it looks like the tests in runner_tests.cljs weren't being run (via the cljsbuild and loading up runtests.html). 0001-ASYNC-184-actually-run-the-runner-tests.patch causes those tests to be run

Show
Kevin Downey added a comment - I am not 100% on how all the clojurescript stuff works, but it looks like the tests in runner_tests.cljs weren't being run (via the cljsbuild and loading up runtests.html). 0001-ASYNC-184-actually-run-the-runner-tests.patch causes those tests to be run
Hide
Kevin Downey added a comment -

0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch is a port of the clojure exception fixes in ASYNC-169 to clojurescript, includes some tests based on other cljs core.async issues

Show
Kevin Downey added a comment - 0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch is a port of the clojure exception fixes in ASYNC-169 to clojurescript, includes some tests based on other cljs core.async issues
Hide
Kevin Downey added a comment -

I updated 0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch to fix ASYNC-198 on the cljs side

Show
Kevin Downey added a comment - I updated 0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch to fix ASYNC-198 on the cljs side
Hide
Kevin Downey added a comment -

0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch updated to have better exceptions when a try/catch/finally is malformed

Show
Kevin Downey added a comment - 0002-ASYNC-184-port-clj-exception-handling-fixes-to-cljs.patch updated to have better exceptions when a try/catch/finally is malformed

People

Vote (1)
Watch (0)

Dates

  • Created:
    Updated: