cljs.js: require macros failure error message pertains to non-macros

Description

Repro, via script/noderepljs:

(require 'cljs.js)

(binding [cljs.js/*load-fn* (fn [x cb] (prn x) (cb nil))]
 (cljs.js/require 'foo.bar {:macros-ns true} prn))

this prints

{:name foo.bar, :macros true, :path "foo/bar"}
{:error #error {:message "No such namespace: foo.bar, could not locate foo/bar.cljs, foo/bar.cljc, or Closure namespace \"foo.bar\"", :data {:tag :cljs/analysis-error}}}

Environment

Shipping Node REPL

Attachments

CLJS-1417.patch

10 Aug, 2015

Activity

David Nolen

August 11, 2015 at 4:14 AM

fixed https://github.com/clojure/clojurescript/commit/637e247dc57695b153f3deb27b9999f77c2fa015

Mike Fikes

August 10, 2015 at 8:17 PM

I created https://clojure.atlassian.net/browse/CLJ-1797#icft=CLJ-1797 covering the 2nd paragraph in the previous comment about require-macros in non-bootstrapped ClojureScript REPLs.

Mike Fikes

August 10, 2015 at 8:07 PM

The attached patch adds a new error message which is careful to list the files off in the order specified here (as is done for the non-macros ns error): https://github.com/clojure/clojurescript/blob/v1.7/src/main/cljs/cljs/js.cljs#L61

This patch is effectively adding an error message that would only be used by bootstrapped environments. It could be further revised so that the same error message is emitted if require-macros is called in a regular ClojureScript REPL for a unlocatable namespace. (This patch doesn't revise that behavior, which results in Clojure complaining about __init.class and clj files, but not cljc---perhaps Clojure itself in the future will be revised to mention cljc.

Resize work item view side panel

Completed

Details

Assignee

David Nolen

Reporter

Mike Fikes

Affects versions

1.7.48

Priority

Major

Created August 10, 2015 at 7:21 PM

Updated August 11, 2015 at 4:14 AM

Resolved August 11, 2015 at 4:14 AM