Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

go ignores async code in letfn body

Description

The following snippet fails because <! is outside of go boundaries.

(let [port (a/chan)] (a/go (letfn [(my-even? [n] (if (zero? n) true (my-odd? (dec n)))) (my-odd? [n] (if (zero? n) false (my-even? (dec n))))] (my-even? (a/<! port)))))

Async code in letfn body should be rewritten by the go macro, given all bound functions can be properly initialized when the body starts.

Environment

None

Attachments

2
  • 16 Oct 2018, 03:07 PM
  • 16 Oct 2018, 02:59 PM

Activity

Show:

leonoel November 19, 2018 at 7:36 PM

Updated example to properly check circular references

leonoel November 19, 2018 at 7:34 PM

No, the fix and the test are both wrong.
The fix doesn't properly establishes circular references and the test fails to check it because it shadows clojure.core's odd?/even?.

Alex Miller November 19, 2018 at 5:42 PM

What's the status on this? 0001-ASYNC-221-handle-letfn-in-ioc+test.patch is the patch?

Nicola Mometto October 16, 2018 at 5:51 PM

Removing bad patch

Details

Assignee

Reporter

Patch

Code and Test

Priority

Created October 16, 2018 at 1:38 PM
Updated January 10, 2020 at 4:13 PM

Flag notifications