Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

PersistentQueue doesn't implement java.util.List, causing nontransitive equality

Description

PersistentQueue implements Sequential but doesn't implement java.util.List. Lists form an equality partition, as do Sequentials. This means that you can end up with nontransitive equality:

(def q (conj clojure.lang.PersistentQueue/EMPTY 1 2 3)) ;=> #user/q (def al (doto (java.util.ArrayList.) (.add 1) (.add 2) (.add 3))) ;=> #user/al (def v [1 2 3]) ;=> #user/v (= al v) ;=> true (= v q) ;=> true (not= al q) ;=> true

This happens because PersistentQueue is a Sequential but not a List, ArrayList is a List but not a Sequential, and PersistentVector is both.

Environment

None

Attachments

3
  • 24 May 2018, 05:39 AM
  • 11 Dec 2012, 07:57 PM
  • 03 Nov 2012, 06:23 PM

Activity

Show:

Andy Fingerhut May 24, 2018 at 5:39 AM

Patch 002-clj-1059-asequential-rebased-to-cached-hasheq-v2.patch is identical to 002-clj-1059-asequential-rebased-to-cached-hasheq.diff, but applies cleanly to latest Clojure master as of 2018-May-23. Kept attribution of the original patch.

Andy Fingerhut August 11, 2014 at 7:37 AM

One or more commits made to Clojure master between Aug 1 2014 and Aug 10 2014 conflict with the patch 001-clj-1059-make-persistentqueue-implement-list.diff, and it no longer applies cleanly.

Andy Fingerhut March 31, 2014 at 11:33 PM

This issue was run into again and a duplicate ticket CLJ-1374 created – later closed as a duplicate of this one. Just wanted to record that this issue is being hit by others besides those originally reporting it.

Andy Fingerhut January 30, 2014 at 10:50 PM

With the commits to Clojure master made in the week leading up to Jan 30 2014, particularly changes to hasheq, patch 002-clj-1059-asequential-rebased-to-cached-hasheq.diff no longer applies cleanly.

Patch 001-clj-1059-make-persistentqueue-implement-list.diff still does.

Philip Potter December 11, 2012 at 7:57 PM

Thanks Andy. Submitted a new patch, 002-clj-1059-asequential-rebased-to-cached-hasheq.diff, which supersedes 002-clj-1059-asequential.diff.

The patch 001-clj-1059-make-persistentqueue-implement-list.diff still applies cleanly, and is still an alternative to 002-clj-1059-asequential-rebased-to-cached-hasheq.diff.

Details

Assignee

Reporter

Labels

Patch

Code and Test

Priority

Affects versions

Created September 3, 2012 at 10:23 AM
Updated May 24, 2018 at 5:39 AM

Flag notifications