Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Suppress warnings when clojure.core symbols are explicitly replaced with "use" or "refer"

Description

Problem: Libraries that provide DSLs (such as core.matrix) often replace or extend functions in core (such as "+", "==", "zero?"), since it is desirable to use the best / most idiomatic names.

Currently importing such libraries with "use" causes unwanted warnings like "WARNING: + already refers to: #'clojure.core/+ in namespace: test.blank, being replaced by: #'clojure.core.matrix/+".

Avoiding these warnings requires extra user effort and boilerplate code, which is frustrating for users since they have already explicitly asked for the full library to be imported into the current namespace (i.e. via "use" or ":refer :all").

Proposed solution is to introduce a new var warn-on-replace similar to warn-on-reflection which allows this warning to be controlled.

Environment

None

Attachments

2

Activity

Show:

Alex Miller May 7, 2017 at 9:57 PM

It doesn't look like the patch was ever updated from the last discussion about the current patch, so it's never been screened. I think I would follow the path of `warn-on-reflection` rather than compiler options.

import May 5, 2017 at 11:32 PM

Comment made by: jmromrell

Did anything ever come of this? I am trying to resolve similar warnings from monger, among other libraries.

Alex Miller June 9, 2015 at 4:50 PM

Linking to CLJ-1746 as related.

Mike Anderson August 30, 2014 at 1:00 AM

I'm happy to update the patch, just need feedback on which approach / solution to this problem is preferred.

I'd really like to see this in 1.7!

Andy Fingerhut August 29, 2014 at 10:37 PM

As before, I can't comment on whether there is interest in this ticket or these patches, but I can say that all patches dated Sep 7 2013 and earlier no longer applied cleanly to latest master after some commits were made to Clojure on Aug 29, 2014. They did apply cleanly before that day.

I have not checked how easy or difficult it might be to update this patch.

Details

Assignee

Reporter

Labels

Patch

Code

Priority

Affects versions

Created September 7, 2013 at 4:33 AM
Updated September 26, 2022 at 10:40 PM