Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Better primitive support for floats

Description

Clojure offers optimized arithmetic functions for long, int and doubles but none for floats.
Plus converting from integers (ints or longs) to floating point numbers (float or double) doesn't use the specialized bytecode.
This patch adds float-add/subtract/multiply/divide and more efficient coversion from integers to floating points numbers.

Environment

None

Attachments

2

Activity

Show:

Christophe Grand February 5, 2014 at 11:40 PM

Godd thing I had already split coercions in a sparate commit then

See http://dev.clojure.org/jira/browse/CLJ-1340

Alex Miller February 5, 2014 at 11:22 PM

No, but totally my fault for saying the wrong words.

I think the changes in Compiler to get access to I2D, L2D, I2F, and L2F are potentially useful (most particularly L2D) - these would make sense in a new ticket.

The other changes in Intrinsics and Numbers to support float math are unlikely to be accepted.

Christophe Grand February 5, 2014 at 10:20 PM

I attached a new patch with only intrinsics and more comprehensive primitive coercion. Is it the split you expected?

Alex Miller February 5, 2014 at 6:29 PM

I think it's unlikely the arithmetic float ops will be accepted.
However, the intrinsics changes could be useful - could you split those into a new ticket?

Details

Assignee

Reporter

Labels

Patch

Code

Priority

Affects versions

Created September 26, 2013 at 3:04 PM
Updated May 15, 2017 at 9:47 PM