Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

aset-* and aget perform poorly on multi-dimensional arrays even with type hints.

Description

Here's a transcript of the behavior. I don't know for sure that reflection is being done, but the performance penalty (about 1300x) suggests it.

One workaround is to use multiple agets.

Cause: The inlined version only applies to arity 2, and otherwise it reflects.

Environment

Clojure 1.5.1.

Dependencies: criterium

Attachments

4

Activity

Show:

Alexander Yakushev August 2, 2022 at 1:30 PM

Uploaded patch P3 with a minor change to how inlining is suppressed in non-inlined version of the functions.

Alexander Yakushev July 31, 2019 at 8:39 PM

Bump – can you consider picking this up again for 1.11? The patch is complete; however, if it seems too complicated, it can be simplified.

 

Alexander Yakushev September 17, 2018 at 2:49 PM

Thanks for the answer. In terms of complexity, I can remove the part that "optimizes" reflective calls, which both simplifies the algorithm and makes the reflection sites visible to the compiler (and thus to the user).

Alex Miller September 17, 2018 at 2:33 PM

It's complicated, not sure if its worth this or not. Probably won't look at it for 1.10.

Alexander Yakushev September 15, 2018 at 8:53 AM

Is there a chance to review this for 1.10? Perhaps, the implementation is too complicated and needs more time to consider? I might try to reduce the scope then.

Details

Assignee

Reporter

Labels

Approval

Triaged

Patch

Code

Priority

Affects versions

Created November 1, 2013 at 6:33 PM
Updated November 19, 2024 at 2:59 AM