[#CLJ-1320] min-key assumes numbers, not comparables. - Clojure JIRA

Details

Type: Enhancement
Status: Closed
Priority: Major
Resolution: Declined
Affects Version/s: Release 1.2, Release 1.3, Release 1.4, Release 1.5, Release 1.6
Fix Version/s: None
Component/s: None
Labels:
None

Patch:
Code

Description

The min-key function assumes the key-fn will yield a number and thus uses the '<' operator to compare results.
There are cases where one might want to use min-key with comparables instead.

While (first (sort-by key-fn seq)) could also be used, it feels more natural for min-key to use comparables.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

min-key.diff

09/Jan/14 9:04 AM

0.7 kB

Pierre-Yves Ritschard

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Pierre-Yves Ritschard added a comment - 09/Jan/14 3:18 PM

As discussed on the .L, since compare is slower it makes more sense to keep min-key as-is.

Show

Pierre-Yves Ritschard added a comment - 09/Jan/14 3:18 PM As discussed on the .L, since compare is slower it makes more sense to keep min-key as-is.

Hide

Permalink

Michael Blume added a comment - 10/Jul/15 6:15 PM

Instead of changing min-key, would it make sense to have a different function which takes a comparator instead of a key function?

Show

Michael Blume added a comment - 10/Jul/15 6:15 PM Instead of changing min-key, would it make sense to have a different function which takes a comparator instead of a key function?

People

Assignee:

Unassigned

Reporter:

Pierre-Yves Ritschard

Vote (0)

Watch (1)

Dates

Created:

09/Jan/14 9:04 AM

Updated:

10/Jul/15 6:15 PM

Resolved:

09/Jan/14 3:19 PM