Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

doseq with several bindings causes "ClassFormatError: Invalid Method Code length"

Description

Important Perf Note the new impl is faster for collections that are custom-reducible but not chunked, and is also faster for large numbers of bindings. The original implementation is hand tuned for chunked collections, and wins for larger chunked coll/smaller binding count scenarios, presumably due to the fn call/return tracking overhead of reduce. Details are in the comments.
Screened By
Patch doseq.patch

While this example is silly, it's a problem we've hit a couple of times. It's pretty surprising when you have just a couple of lines of code and suddenly you get the code length error.

Environment

Clojure 1.5.1, java 1.7.0_25, OpenJDK Runtime Environment (IcedTea 2.3.10) (7u25-2.3.10-1ubuntu0.12.04.2)

Attachments

3

Activity

Show:

Ghadi Shayban April 24, 2016 at 6:25 AM

Example doseq impl and macroexpansion that does not suffer exponential bytecode growth. It also doesn't use any lambdas, so suitable for core.async.
https://gist.github.com/ghadishayban/fe84eb8db78f23be68e20addf467c4d4
It uses an explicit stack for the seqs/bindings.
It does not handle any chunking or modifiers yet.

Nicola Mometto September 3, 2015 at 6:59 PM

The general solution to this would be to automatically split methods when too large, using something like https://bitbucket.org/sperber/asm-method-size

Nicola Mometto March 26, 2015 at 12:07 AM

Related: CLJ-77

Ghadi Shayban September 22, 2014 at 10:36 PM

The current expansion of a doseq [1] under a go form is less than ideal due to the amount of control flow. 14 states in the state machine vs. 7 with loop/recur

[1] Comparison of macroexpansion of (go ... doseq) vs (go ... loop/recur)
https://gist.github.com/ghadishayban/639009900ce1933256a1

Rich Hickey August 29, 2014 at 2:19 PM

Please consider Ghadi's feedback, esp re: closures.

Details

Assignee

Reporter

Approval

Vetted

Patch

Code

Priority

Affects versions

Created January 10, 2014 at 12:17 PM
Updated October 2, 2019 at 2:27 PM