Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Primitive VecSeq does not implement equals or hashing methods

Description

VecSeq (as produced by (seq (vector-of :long 1 2 3))) does not implements equals, hashCode, or hasheq and does not play with any other Clojure collections or sequences appropriately in this regard.

Approach: Implement Object.hashCode(), Object.equals(), and IHashEq.hasheq() in the primitive vector seq implementation. All of these leverage the prim vec seq itself rather than the underlying prim vec as it was quite a big simpler. The hasheq() impl calls Murmur3/hashOrdered, which takes an Iterable, so Iterable was also implemented using an iterator over the seq.

Some existing tests were expanded to include coverage of the primitive vec seq.

Patch: clj-1364-2.patch

Environment

None

Attachments

2

Activity

Show:

Alex Miller October 19, 2020 at 3:37 PM

The example in the description was actually wrong - it was using vector-of :int instead of vector-of :long. However, I also added a new patch that makes the equals case more similar to the equiv.

Stuart Halloway October 19, 2020 at 12:50 PM

I expected to find that equals would copy the existing equiv except for the comparison test, but it differs also in the construction of the cond, local names, and in (unnecessarily?) calling seq on itself.

Stuart Halloway October 19, 2020 at 12:44 PM

After applying the patch, I still see .equals returning false, in both directions.

Andy Fingerhut December 29, 2019 at 2:40 AM

Went ahead and created similar to this one in that they are both regarding interfaces that seqs on normal vectors implement, but VecSeq does not.

Andy Fingerhut December 29, 2019 at 2:31 AM

VecSeq also does not implement interface IObj, whereas calling seqon a regular Clojure vector results in an object that does implement that interface. Any interest in piling additional changes to this ticket for that, or making a separate ticket for it?

Fixed

Details

Assignee

Reporter

Labels

Approval

Ok

Patch

Code and Test

Priority

Affects versions

Fix versions

Created February 19, 2014 at 3:48 PM
Updated October 30, 2020 at 8:30 PM
Resolved October 30, 2020 at 8:30 PM