Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Exception on protocol implementation after protocol reloaded could be improved

Description

In a situation where you define a protocol, and then define a class that extends that protocol (e.g., reify, defrecord, deftype) and then later, re-define the protocol (typically, by reloading the namespace that defines the protocol), then the existing instances are no longer valid.

However, the exception that gets generated can be confusing:

java.lang.IllegalArgumentException: No implementation of method: :injections of protocol: #'fan.microservice/MicroService found for class: fan.auth.AuthService clojure.core/-cache-protocol-fn core_deftype.clj: 544 fan.microservice/eval23300/fn/G microservice.clj: 12 clojure.core/map/fn core.clj: 2559 clojure.lang.LazySeq.sval LazySeq.java: 40 clojure.lang.LazySeq.seq LazySeq.java: 49 clojure.lang.Cons.next Cons.java: 39 clojure.lang.RT.boundedLength RT.java: 1654 clojure.lang.RestFn.applyTo RestFn.java: 130 clojure.core/apply core.clj: 626 fan.microservice.StandardContainer/construct-ring-handler microservice.clj: 51

The confusing part is that (in the above example) AuthService does extend MicroService, just not the correct version of it.

The exception message should be extended to identify that this is "possibly because the protocol was reloaded since the class was defined."

A patch will be ready shortly.

Environment

None

Attachments

1
  • 04 Aug 2014, 06:15 PM

Activity

Show:

Howard Lewis Ship August 4, 2014 at 6:15 PM

Patch with tests

Details

Assignee

Reporter

Labels

Approval

Triaged

Patch

Code and Test

Priority

Affects versions

Created August 4, 2014 at 5:50 PM
Updated November 7, 2014 at 9:14 PM

Flag notifications