Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

data/diff does not return a tuple when comparing different maps

Description

Problem: clojure.data/diff inconsistently returns a lazy seq when comparing different maps, but a vector otherwise.

This is inconsistent with doc and normal behavior :

The docstring states: "Recursively compares a and b, returning a tuple of [things-only-in-a things-only-in-b things-in-both]", implying that it should always return a vector.

Environment

all

Attachments

2

Activity

Show:

Eric Dvorsak January 16, 2016 at 5:27 PM

More strict tests checking for a returned vector.

Eric Dvorsak January 16, 2016 at 5:08 PM

@Alex Miller : I noticed a bug in my program behavior and traced it down to a (get diff 2) instead of (nth diff 2), but I realized that it was only buggy in some cases so I looked further and found out if was coming from diff.

Eric Dvorsak January 16, 2016 at 5:05 PM

Simple patch that just does for maps what is done for lists : Creates a new vector with the vec function.

Alex Miller January 16, 2016 at 4:33 PM

The test may need to be made more strict, checking not just for sequential equality but also for a returned vector.

Just curious - was this issue causing a problem in your code or did you just notice it and find it surprising?

Eric Dvorsak January 16, 2016 at 4:20 PM

There is a test case that should already fail :

I get

Details

Assignee

Reporter

Approval

Triaged

Priority

Affects versions

Created January 16, 2016 at 3:40 PM
Updated January 16, 2016 at 5:27 PM