[spec] recursion-limit not respected
Key details
Description
Environment
1.9.0-alpha11
Activity
import
September 12, 2018 at 9:56 AM
Comment made by: kenran
The first example works fine for me as well, but I'm having a problem mostly similar to the second one. The following code runs into a StackOverflow pretty quickly unless I set :gen-max or :max-count to a low value (e.g. 2):
(require '[clojure.spec.alpha :as s])
(require '[clojure.spec.gen.alpha :as gen])
(s/def ::bar string?)
(s/def ::baz (s/coll-of (s/or :s string? :b ::foo)))
(s/def ::foo
(s/spec
map?
:gen
#(s/gen
(s/keys :req [::bar ::baz]))))
(gen/generate (s/gen ::foo))The s/spec (or s/with-gen, which I also tried) seem to be the problem here, because the following works well and should produce equivalent data:
(s/def ::bar2 string?)
(s/def ::baz2 (s/coll-of (s/or :s2 string? :b2 ::foo2)))
(s/def ::foo2 (s/keys :req [::bar2 ::baz2]))
(gen/generate (s/gen ::foo2))I'm using java 10.0.2 64 bit, but a colleague can reproduce it with the latest java 8.
Am I using it incorrectly or is there a problem hidden somewhere?
import
October 19, 2016 at 10:32 AM
Alex Miller
August 26, 2016 at 5:31 PM
Leon Grapenthin
July 12, 2016 at 7:03 PM
Details
Assignee
Unassigned
UnassignedReporter
import
importApproval
Triaged
Priority
MajorAffects versions
Created July 8, 2016 at 10:05 AM
Updated September 12, 2018 at 9:58 AM
(Also see closed http://dev.clojure.org/jira/browse/CLJ-1964)
(require '[clojure.spec :as s]) (s/def ::map-tree (s/map-of keyword? (s/or :tree ::map-tree :leaf nil?))) (s/exercise ::map-tree)hangs on my machine.
Another example from https://groups.google.com/forum/#!topic/clojure/IvKJc8dEhts, which immediately results in a StackOverflowError on my machine:
(require '[clojure.spec.gen :as gen]) (defrecord Tree [name children]) (defrecord Leaf [name]) (s/def ::name string?) (s/def ::children (s/coll-of (s/or :tree ::Tree, :leaf ::Leaf))) (s/def ::Leaf (s/with-gen (s/keys :req-un [::name]) #(gen/fmap (fn [name] (->Leaf name)) (s/gen ::name)))) (s/def ::Tree (s/with-gen (s/keys :req-un [::name ::children]) #(gen/fmap (fn [[name children]] (->Tree name children)) (s/gen (s/tuple ::name ::children))))) ;; occasionally generates but usually StackOverflow (binding [s/*recursion-limit* 1] (gen/generate (s/gen ::Tree))) StackOverflowError clojure.lang.RT.seqFrom (RT.java:533) clojure.lang.RT.seq (RT.java:527) clojure.core/seq--6221 (core.clj:137) clojure.core/map/fn--6687 (core.clj:2736) clojure.lang.LazySeq.sval (LazySeq.java:40) clojure.lang.LazySeq.seq (LazySeq.java:49) clojure.lang.RT.seq (RT.java:525) clojure.core/seq--6221 (core.clj:137) clojure.core/every? (core.clj:2652) clojure.spec/tuple-impl/reify--13509 (spec.clj:905) clojure.spec/gensub (spec.clj:228) clojure.spec/gen (spec.clj:234)