Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

lazy seq that encounters an exception has differing behavior on repeated use

Description

It seems the below does not compile with 1.8.0 and 1.9.0-alpha14, the same errors appear in both versions.

Patch: 0002-CLJ-2069-cache-exceptions-thrown-during-lazy-seq-rea.patch

Proposal: Cache exceptions thrown during lazy-seq realization, to avoid re-running bodyfn which is declared as `^:once`

Environment

OS X EI Capitan, Java HotSpot(TM) 64-Bit Server VM 1.8.0_101-b13

Attachments

2

Activity

Show:

Ambrose Bonnaire-Sergeant September 20, 2021 at 8:24 PM
Edited

Augmented patch with tests as 0002-CLJ-2069-cache-exceptions-thrown-during-lazy-seq-rea.patch. Added co-author metadata, otherwise retained attribution.

Nicola Mometto November 28, 2016 at 9:36 AM

Attached patch that fixes this issue

Nicola Mometto November 28, 2016 at 9:27 AM

The NPE is caused by the interaction between:

  • lazy-seq throwing an exception while realizing part of the sequence

  • lazy-seq internally using ^:once for locals clearing

lazy-seq expects the bodyfn to be run exactly once and then the result to be cached, but if an exception gets thrown during the execution of bodyfn, the function will get run again when the sequence tries to be realized a second time. However if locals clearing has already happened (even partially) this means some locals in bodyfn will now be nil rather than holding their actual value.

import November 27, 2016 at 4:42 PM

Comment made by: find_my_way

Maybe I should use take-while instead of filter.

However, can anyone explain why I get ArithmeticException while running

for the first time and get the right result at the second time?

Details

Assignee

Reporter

Labels

Approval

Triaged

Patch

Code and Test

Priority

Affects versions

Created November 27, 2016 at 4:20 PM
Updated September 26, 2022 at 4:03 AM