Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

[spec] Reduce collection generator default size from 20

Description

In general I find that it is very easy (especially with nested or recursive collections) to have a check run OOME due to generating very large nested collections. Currently the default is 20 - I think we should change it to 3.

The attached patch just changes the default from 20 to 3. An alternate approach would be to change it to a dynvar setting.

Patch: clj-2102-3.patch

Environment

None

Attachments

3

Activity

Show:

Alex Miller May 12, 2017 at 9:23 PM

Use dynamic var and reduce default. Also consider ways to avoid this kind of problem in test.check itself (how does quickcheck deal with this?).

Stuart Halloway May 12, 2017 at 4:32 PM

I have definitely seen the pain here – nested collections can get big fast. OTOH for non-nested collections the larger generator is nice. Not sure moving the default is a help.

Alex Miller May 10, 2017 at 6:54 PM

Updated patch to apply to spec.alpha

Alex Miller April 7, 2017 at 9:45 PM

Updated patch to apply to master

Details

Assignee

Reporter

Labels

Approval

Vetted

Patch

Code

Priority

Affects versions

Created January 25, 2017 at 3:33 PM
Updated October 2, 2019 at 2:27 PM