Clojure

clojure.repl/source chokes when reading code with ::auto/resolved keys

Details

  • Type: Defect Defect
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Reproduction

foo.clj
(ns foo
  (:require [clojure.java.io :as io]))

(defn f [] ::io/key)
repl
Clojure 1.10.0-alpha4
user=> (require 'foo)
nil
user=> (source foo/f)
RuntimeException Invalid token: ::io/key  clojure.lang.Util.runtimeException (Util.java:221)

Problem analysis
source calls read, without any underlying binding or notion of Compiler.currentNS(), which causes aliased keywords to fail to resolve.

Possible solution
Bind *reader-resolver* to the following before reading:

(reify LispReader$Resolver
  (currentNS [_] 'ignored)
  (resolveClass [_ sym] 'ignored)
  (resolveAlias [_ sym] 'ignored)
  (resolveVar [_ sym] 'ignored))

Aside, the logic inside source-fn can be simplified with read+string, modulo CLJ-2358

Activity

There are no comments yet on this issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated: