Clojure

Move unchecked-prim casts to clojure.unchecked

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: Backlog
  • Fix Version/s: Backlog
  • Component/s: None
  • Labels:
  • Patch:
    Code and Test
  • Approval:
    Vetted

Description

Per Rich's comment in CLJ-767:

Moving unchecked coercions into unchecked ns is ok

Attachments

  1. Text File
    clj-771-move-unchecked-casts-patch-v5.txt
    13/Feb/13 12:50 AM
    12 kB
    Andy Fingerhut
  2. Text File
    move-unchecked-casts.patch
    29/Apr/11 3:41 PM
    12 kB
    Alexander Taggart
  3. Text File
    move-unchecked-casts-v2.patch
    19/May/12 9:36 AM
    12 kB
    John Szakmeister

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alexander Taggart added a comment -

Requires that patch on CLJ-782 be applied first.

Show
Alexander Taggart added a comment - Requires that patch on CLJ-782 be applied first.
Hide
Permalink
Stuart Sierra added a comment -

Applies on master as of commit 66a88de9408e93cf2b0d73382e662624a54c6c86

Show
Stuart Sierra added a comment - Applies on master as of commit 66a88de9408e93cf2b0d73382e662624a54c6c86
Hide
Permalink
Rich Hickey added a comment -

still considering when to incorporate this

Show
Rich Hickey added a comment - still considering when to incorporate this
Hide
Permalink
John Szakmeister added a comment -

v2 of the patch applies to master as of commit eccde24c7fb63679f00c64b3c70c03956f0ce2c3

Show
John Szakmeister added a comment - v2 of the patch applies to master as of commit eccde24c7fb63679f00c64b3c70c03956f0ce2c3
Hide
Permalink
Andy Fingerhut added a comment -

Patch clj-771-move-unchecked-casts-patch-v3.txt dated Sep 6 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.

Show
Andy Fingerhut added a comment - Patch clj-771-move-unchecked-casts-patch-v3.txt dated Sep 6 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.
Hide
Permalink
Andy Fingerhut added a comment -

Patch clj-771-move-unchecked-casts-patch-v4.txt dated Oct 20 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.

Show
Andy Fingerhut added a comment - Patch clj-771-move-unchecked-casts-patch-v4.txt dated Oct 20 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.
Hide
Permalink
Andy Fingerhut added a comment -

The patch clj-771-move-unchecked-casts-patch-v4.txt applies cleanly to latest master and passes all tests. Rich marked this ticket as Incomplete on Dec 9 2011 with the comment "still considering when to incorporate this" above. Is it reasonable to change it back to Vetted or Screened so it can be considered again, perhaps after Release 1.5 is made?

Show
Andy Fingerhut added a comment - The patch clj-771-move-unchecked-casts-patch-v4.txt applies cleanly to latest master and passes all tests. Rich marked this ticket as Incomplete on Dec 9 2011 with the comment "still considering when to incorporate this" above. Is it reasonable to change it back to Vetted or Screened so it can be considered again, perhaps after Release 1.5 is made?
Hide
Permalink
Andy Fingerhut added a comment -

Patch clj-771-move-unchecked-casts-patch-v5.txt dated Feb 12 2013 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.

Show
Andy Fingerhut added a comment - Patch clj-771-move-unchecked-casts-patch-v5.txt dated Feb 12 2013 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.