memoization of js-dependency-index and get-upstream-deps needs knobs

Description

knobs should be exposed for more dynamic compilation environments like Figwheel which may desire to add dependencies to the classpath on the fly.

Environment

None

Attachments

2
  • 28 Mar 2015, 09:43 PM
  • 21 Mar 2015, 09:51 PM

Activity

Show:

David Nolen February 25, 2022 at 4:18 PM

Not going to do this one.

Mike Fikes November 20, 2017 at 2:04 AM

Patch no longer applies.

Bruce Hauman March 28, 2015 at 9:43 PM

Alright, this latest patch works. There was a subtle memoizing nil value bug.

Bruce Hauman March 28, 2015 at 8:44 PM

Yeah there is an obvious bug and a subtle one. Hopefully will finish it up soonish.

David Nolen March 28, 2015 at 8:26 PM

Thanks for the update. This will definitely not land until after the pending REPL/piggieback release anyhow.

Fixed

Details

Assignee

Reporter

Patch

Code

Fix versions

Affects versions

Priority

Created March 18, 2015 at 6:05 AM
Updated February 25, 2022 at 4:18 PM
Resolved February 25, 2022 at 4:18 PM

Flag notifications