ClojureScript

data_readers.cljc

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: 1.7.145
  • Fix Version/s: 1.9.655
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

Now that conditional reading has landed we can implement support for data_readers.cljc to get both compile time and runtime support.

Activity

Hide
David Nolen added a comment - - edited
Show
David Nolen added a comment - - edited This needs http://dev.clojure.org/jira/browse/CLJ-1699 to be useful.
Hide
Nikita Prokopov added a comment -

CLJ-1699 has landed.

Right now CLJS tries to compile data_readers.cljc as a regular source code file:

Exception in thread "main" java.lang.AssertionError: No ns form found in src/data_readers.cljc, compiling:(/private/var/folders/0h/9vv4g3d955l6ctwwl4k9xjy40000gn/T/form-init3533791126017861878.clj:1:125)
	at clojure.lang.Compiler.load(Compiler.java:7249)
	at clojure.lang.Compiler.loadFile(Compiler.java:7175)
	at clojure.main$load_script.invoke(main.clj:275)
	at clojure.main$init_opt.invoke(main.clj:280)
	at clojure.main$initialize.invoke(main.clj:308)
	at clojure.main$null_opt.invoke(main.clj:343)
	at clojure.main$main.doInvoke(main.clj:421)
	at clojure.lang.RestFn.invoke(RestFn.java:421)
	at clojure.lang.Var.invoke(Var.java:383)
	at clojure.lang.AFn.applyToHelper(AFn.java:156)
	at clojure.lang.Var.applyTo(Var.java:700)
	at clojure.main.main(main.java:37)
Show
Nikita Prokopov added a comment - CLJ-1699 has landed. Right now CLJS tries to compile data_readers.cljc as a regular source code file:
Exception in thread "main" java.lang.AssertionError: No ns form found in src/data_readers.cljc, compiling:(/private/var/folders/0h/9vv4g3d955l6ctwwl4k9xjy40000gn/T/form-init3533791126017861878.clj:1:125)
	at clojure.lang.Compiler.load(Compiler.java:7249)
	at clojure.lang.Compiler.loadFile(Compiler.java:7175)
	at clojure.main$load_script.invoke(main.clj:275)
	at clojure.main$init_opt.invoke(main.clj:280)
	at clojure.main$initialize.invoke(main.clj:308)
	at clojure.main$null_opt.invoke(main.clj:343)
	at clojure.main$main.doInvoke(main.clj:421)
	at clojure.lang.RestFn.invoke(RestFn.java:421)
	at clojure.lang.Var.invoke(Var.java:383)
	at clojure.lang.AFn.applyToHelper(AFn.java:156)
	at clojure.lang.Var.applyTo(Var.java:700)
	at clojure.main.main(main.java:37)
Hide
David Nolen added a comment -

This should be addressed first: http://dev.clojure.org/jira/browse/CLJS-1277

Show
David Nolen added a comment - This should be addressed first: http://dev.clojure.org/jira/browse/CLJS-1277
Hide
António Nuno Monteiro added a comment -

Attached patch with fix and tests.

Show
António Nuno Monteiro added a comment - Attached patch with fix and tests.

People

Vote (2)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: