ClojureScript

cljs.compiler/load-libs does not preserve user expressed require order

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: 1.7.145
  • Fix Version/s: 1.9.655
  • Component/s: None
  • Labels:
    None

Description

Due to putting the requires into a map the original order is lost. This is a problem primarily when order specific side effects are present in the required namespaces.

Activity

Hide
Angus Fletcher added a comment - - edited

This patch changes deps in parse 'ns and parse 'ns* to be a vector, which gives us deterministic ordering in load-libs.

Show
Angus Fletcher added a comment - - edited This patch changes deps in parse 'ns and parse 'ns* to be a vector, which gives us deterministic ordering in load-libs.
Hide
Angus Fletcher added a comment -

Patch, updated to remove whitespace changes.

Show
Angus Fletcher added a comment - Patch, updated to remove whitespace changes.

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: