ClojureScript

Update Closure Compiler to v20160208

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: 1.9.76
  • Fix Version/s: None
  • Component/s: None
  • Labels:

Description

Now that Closure Cmopiler v20160208 has been pushed to Maven Central, update to that version.

Activity

Hide
Linus Ericsson added a comment -

Success report:

I applied update-closure-compiler-v20160208.patch to f58dcdf4 (22 feb) and successfully built clojurescript.

I added the resulting [org.clojure/clojurescript "1.8.28"] to a non-trivial reagent/figwheel based project.clj and updated its closure dependency as well.

I managed to start the repl and everything seem to work fine, these warnings are shown after upgrading clojurescript:

WARNING: Unknown option ':compiler-env'.
WARNING: Unknown option ':special-fns'.
WARNING: Unknown option ':warn-on-undeclared'.

I have not read all the changes to ClojureScript and therefore assume this is just some regression for changed compiler options.

$lein figwheel
Figwheel: Starting server at http://localhost:3449
Figwheel: Watching build - dev
Compiling "resources/public/js/compiled/frontlyft.js" from ["src" "../delat_src"]...
Successfully compiled "resources/public/js/compiled/frontlyft.js" in 1.693 seconds.
Figwheel: Starting CSS Watcher for paths ["resources/public/css"]
Launching ClojureScript REPL for build: dev
Figwheel Controls:
(stop-autobuild) ;; stops Figwheel autobuilder
(start-autobuild [id ...]) ;; starts autobuilder focused on optional ids
(switch-to-build id ...) ;; switches autobuilder to different build
(reset-autobuild) ;; stops, cleans, and starts autobuilder
(reload-config) ;; reloads build config and resets autobuild
(build-once [id ...]) ;; builds source one time
(clean-builds [id ..]) ;; deletes compiled cljs target files
(print-config [id ...]) ;; prints out build configurations
(fig-status) ;; displays current state of system
Switch REPL build focus:
:cljs/quit ;; allows you to switch REPL to another build
Docs: (doc function-name-here)
Exit: Control+C or :cljs/quit
Results: Stored in vars *1, *2, *3, *e holds last exception object
Prompt will show when Figwheel connects to your application
WARNING: Unknown option ':compiler-env'.
WARNING: Unknown option ':special-fns'.
WARNING: Unknown option ':warn-on-undeclared'.
To quit, type: :cljs/quit

These are the dependencies

:dependencies [[org.clojure/clojure "1.8.0"]
[org.clojure/clojurescript "1.8.28"]
[org.clojure/core.async "0.2.374"]
[reagent "0.5.1"]
[timothypratley/reanimated "0.1.4"]
[cljsjs/react "0.14.3-0"]
[com.andrewmcveigh/cljs-time "0.4.0"]
[com.google.javascript/closure-compiler "v20160208"]
[datascript "0.15.0"]
[cljs-http "0.1.39"]
[secretary "1.2.3" :exclusion [org.clojure/clojurescript]]]

:plugins [[lein-cljsbuild "1.1.2" :exclusion [org.clojure/clojure]]
[lein-figwheel "0.5.0-6"]]

Show
Linus Ericsson added a comment - Success report: I applied update-closure-compiler-v20160208.patch to f58dcdf4 (22 feb) and successfully built clojurescript. I added the resulting [org.clojure/clojurescript "1.8.28"] to a non-trivial reagent/figwheel based project.clj and updated its closure dependency as well. I managed to start the repl and everything seem to work fine, these warnings are shown after upgrading clojurescript: WARNING: Unknown option ':compiler-env'. WARNING: Unknown option ':special-fns'. WARNING: Unknown option ':warn-on-undeclared'. I have not read all the changes to ClojureScript and therefore assume this is just some regression for changed compiler options. $lein figwheel Figwheel: Starting server at http://localhost:3449 Figwheel: Watching build - dev Compiling "resources/public/js/compiled/frontlyft.js" from ["src" "../delat_src"]... Successfully compiled "resources/public/js/compiled/frontlyft.js" in 1.693 seconds. Figwheel: Starting CSS Watcher for paths ["resources/public/css"] Launching ClojureScript REPL for build: dev Figwheel Controls: (stop-autobuild) ;; stops Figwheel autobuilder (start-autobuild [id ...]) ;; starts autobuilder focused on optional ids (switch-to-build id ...) ;; switches autobuilder to different build (reset-autobuild) ;; stops, cleans, and starts autobuilder (reload-config) ;; reloads build config and resets autobuild (build-once [id ...]) ;; builds source one time (clean-builds [id ..]) ;; deletes compiled cljs target files (print-config [id ...]) ;; prints out build configurations (fig-status) ;; displays current state of system Switch REPL build focus: :cljs/quit ;; allows you to switch REPL to another build Docs: (doc function-name-here) Exit: Control+C or :cljs/quit Results: Stored in vars *1, *2, *3, *e holds last exception object Prompt will show when Figwheel connects to your application WARNING: Unknown option ':compiler-env'. WARNING: Unknown option ':special-fns'. WARNING: Unknown option ':warn-on-undeclared'. To quit, type: :cljs/quit These are the dependencies :dependencies [[org.clojure/clojure "1.8.0"] [org.clojure/clojurescript "1.8.28"] [org.clojure/core.async "0.2.374"] [reagent "0.5.1"] [timothypratley/reanimated "0.1.4"] [cljsjs/react "0.14.3-0"] [com.andrewmcveigh/cljs-time "0.4.0"] [com.google.javascript/closure-compiler "v20160208"] [datascript "0.15.0"] [cljs-http "0.1.39"] [secretary "1.2.3" :exclusion [org.clojure/clojurescript]]] :plugins [[lein-cljsbuild "1.1.2" :exclusion [org.clojure/clojure]] [lein-figwheel "0.5.0-6"]]
Hide
Michael Zhou added a comment -

Is there an update on this?

Show
Michael Zhou added a comment - Is there an update on this?
Hide
Michael Zhou added a comment -

Thanks!

Show
Michael Zhou added a comment - Thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: