fixed https://github.com/clojure/clojurescript/commit/f289ffee2270567f7976d45012a0a52c38eb6488

CLJS-1702-10.patch rebaselines

Thanks will review.

CLJS-1702-9.patch is the same as CLJS-1702-8.patch, except that it eliminates an explicit deref call that had been added, reverting to using @.

CLJS-1702-8.patch dispenses with the metadata.

There are two odd cases that arose in this last patch:

1. Since the private checked-get (and friends) specifically trigger analysis warnings based on their symbol (see https://github.com/clojure/clojurescript/blob/6950aff480174a25a77c2308aa87a099a774a6e8/src/main/clojure/cljs/analyzer.cljc#L3558), attempting to use var indirection to avoid private var warnings on them defeats the strategy of triggering the logic on those symbols. The latest patch fixes that by piling on a little more special handling for those symbols, suppressing the private var warning for them.

2. If you spec some private functions and then, from another namespace, enable spec instrumentation, the macros involved end up calling set! on the relevant symbols, and, since they are private, the private var warning will trigger. I couldn't think of a clean way to cope with this, so the revised patch takes the heavy-handed approach of simply turning off private var access warnings when analyzing set! forms. (Perhaps this is OK: when you are using set! and the target happens to be a var, you are already doing something a bit advanced in your code and presumably you know what you are doing?)