ClojureScript

User supplied externs not loaded with user specified compiler state

Details

  • Type: Defect Defect
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

User supplied externs for use with warn-on-infer are only loaded in the 2-arity versions of cljs.closure/build, cljs.build.api/build and cljs.build.api/watch when compiler is nil.

Note: This only affects the warnings that are generated by the analyzer with warn-on-infer; the externs are correctly passed to gclosure.

Activity

Hide
Jonathan Henry added a comment -

This patch moves the loading of externs from cljs.env/default-compiler-env to cljs.closure/build.

Show
Jonathan Henry added a comment - This patch moves the loading of externs from cljs.env/default-compiler-env to cljs.closure/build.
Hide
Jonathan Henry added a comment -

Ignore this patch, I just realized this makes it so the built-in externs are no longer loaded for the compiler and analyzer API.

Show
Jonathan Henry added a comment - Ignore this patch, I just realized this makes it so the built-in externs are no longer loaded for the compiler and analyzer API.
Hide
David Nolen added a comment -

I deleted the patch to avoid confusion.

Show
David Nolen added a comment - I deleted the patch to avoid confusion.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated: