Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Add end-line and end-column to analyzer AST

Description

Some existing Clojure tooling [1] currently built on top of tools.analyzer.jvm, depend on having end-line and end-column on an AST node.

This data is currently missing from the ClojureScript analyzer, which prevents these tools from being ported to ClojureScript [2]

[1] https://github.com/clojure-emacs/refactor-nrepl
[2] https://github.com/clojure-emacs/refactor-nrepl/issues/195#issuecomment-303910871

Environment

None

Attachments

1

Activity

Show:

David Nolen April 22, 2019 at 7:35 PM

We just need more feedback on this thread. Try the patch and let us know whether source mapping still works.

benedek fazekas April 11, 2019 at 8:18 PM

any progress on this? just realised this is pending while looking at https://github.com/clojure-emacs/refactor-nrepl/issues/195
thanks

David Nolen May 26, 2017 at 10:25 PM

Julien, no need for you to test this, trying to get some outside help here

Julien Fantin May 26, 2017 at 10:16 PM

Unfortunately our main project depends on an older ClojureScript version so I couldn't test this on our main codebase. Are there specific things you'd watch out for?

David Nolen May 26, 2017 at 7:14 PM

This patch looks fine but it would be nice to get some feedback that in fact source mapping is not affected.

Details

Assignee

Reporter

Labels

Priority

Created May 26, 2017 at 5:16 AM
Updated April 22, 2019 at 7:35 PM