ClojureScript

de-dupe externs

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9.908
  • Fix Version/s: Next
  • Component/s: None
  • Labels:
  • Patch:
    Code
  • Approval:
    Vetted

Description

We could possibly call distinct on externs to remove dupes in the common case where externs may appear multiple times accidentally on the classpath.

Activity

Hide
David Nolen added a comment -

I don't think we want to silently dedupe. We probably want to also warn so users can fix the issue. The only reason to even do this ticket is because the Closure warning is so unfriendly and fails the build.

Show
David Nolen added a comment - I don't think we want to silently dedupe. We probably want to also warn so users can fix the issue. The only reason to even do this ticket is because the Closure warning is so unfriendly and fails the build.
Hide
Sameer Rahmani added a comment - - edited

got it, I'll improve the patch

Show
Sameer Rahmani added a comment - - edited got it, I'll improve the patch

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated: