ClojureScript

Closure-Compiler: Intent to Remove AMD Module Support

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Approval:
    Accepted

Description

Hi - I'm a maintainer of Closure-Compiler. The compiler currently has a pass to transform some types of AMD modules to CommonJS so that the CommonJS processing can rewrite the code. It's an old pass and nobody is maintaining it. I'd like to delete it.

I just wanted to check and make sure that Clojure isn't actively using it. If it is, we need to come up with some type of plan.

Thanks,

Chad Killingsworth

Activity

Hide
Juho Teperi added a comment - - edited

We support AMD modules, but no, Cljs doesn't actively use them.

We'll need to be remove references to some options and classes when these are removed from Closure.

Show
Juho Teperi added a comment - - edited We support AMD modules, but no, Cljs doesn't actively use them. We'll need to be remove references to some options and classes when these are removed from Closure.
Hide
Juho Teperi added a comment -

Removed the AMD module support and test cases.

Show
Juho Teperi added a comment - Removed the AMD module support and test cases.
Hide
Mike Fikes added a comment -

See test regression CLJS-2498

Show
Mike Fikes added a comment - See test regression CLJS-2498

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: