Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

`set` and `vec` performance enhancements

Description

On the master branch (and in all previous versions of ClojureScript I've seen), the version of `set` and `vec` in core.cljs do not do an instance check before creating a new set or vector. That is, `set` does not check (as in the Clojure 1.8 version) whether the input is already a set before creating a brand-new one, and `vec` does not check (as in the Clojure 1.8 version) whether the input is already a vector before creating a brand-new one. In addition, `set` appears not to support reducibles (`vec` does not share this defect).

The enhancement is short and simple: the addition of one `instance?` check per function.

Relates to, but does not duplicate, CLJS-1784.

Environment

None

Attachments

1

Activity

Show:

Mike Fikes June 25, 2018 at 9:41 PM

David Nolen June 25, 2018 at 2:00 AM

Looks good, Mike, feel free to apply after we hear that 1.10.335 is good.

Mike Fikes June 24, 2018 at 9:25 PM

The attached patch produces roughly order-of-magnitude speedups for creating sets from sets and vectors from vectors:

What about overhead added by the new checks? These perf test swap things to see what the slowdown is (roughly 10% in many cases):

Completed

Details

Assignee

Reporter

Approval

Accepted

Patch

Code and Test

Priority

Created December 14, 2017 at 5:45 PM
Updated June 25, 2018 at 9:41 PM
Resolved June 25, 2018 at 9:41 PM