Closure compilation errors should stop ClojureScript compilation

Description

If Closure reports error, it is printed by report-failure, but ClojureScript will continue. This can (often will) result in broken output.

This problem can happen with both Module Processing (some files not being processed, e.g. CommonJS code is present in output) and with optimization step. If optimization fails (Closure can't parse some files), optimize doesn't throw but returns nil, which is written to output-file.

Environment

None

Attachments

1

Activity

Show:

David Nolen February 10, 2018 at 12:11 PM

Oops I see that we do. Looks good.

David Nolen February 10, 2018 at 12:10 PM

I think we want to log those errors right? Or do we already do that?

Completed

Details

Assignee

Reporter

Priority

Created February 8, 2018 at 8:30 PM
Updated February 10, 2018 at 12:11 PM
Resolved February 10, 2018 at 12:11 PM