ClojureScript

Refine doc string for defmulti

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.10.238
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Patch:
    Code

Description

CLJ-835 but for ClojureScript.

Perhaps we can copy Clojure's current docstring over en masse, replacing "Clojure" references to "ClojureScript", and ensuring that it is accurate for ClojureScript's defmulti semantics / behavior.

  1. CLJS-2735.patch
    21/Sep/18 8:54 AM
    2 kB
    Pankaj Doharey
  2. CLJS-2735-2.patch
    22/Sep/18 12:37 PM
    2 kB
    Pankaj Doharey
  3. CLJS-2735-3.patch
    22/Sep/18 3:29 PM
    2 kB
    Pankaj Doharey

Activity

Hide
Pankaj Doharey added a comment -

Created a pull request on Github here https://github.com/clojure/clojurescript/pull/79

Show
Pankaj Doharey added a comment - Created a pull request on Github here https://github.com/clojure/clojurescript/pull/79
Hide
Pankaj Doharey added a comment - - edited

Attached a CLJS-2735 patch in any case.

Show
Pankaj Doharey added a comment - - edited Attached a CLJS-2735 patch in any case.
Hide
Mike Fikes added a comment -

Hey Pankaj, thanks for the contribution. Can you make a patch using the instructions here? https://clojurescript.org/community/patches

Show
Mike Fikes added a comment - Hey Pankaj, thanks for the contribution. Can you make a patch using the instructions here? https://clojurescript.org/community/patches
Hide
Pankaj Doharey added a comment - - edited

Hi Mike, just uploaded a new patch based on the instructions on the given page.

Thanks.

Show
Pankaj Doharey added a comment - - edited Hi Mike, just uploaded a new patch based on the instructions on the given page. Thanks.
Hide
Pankaj Doharey added a comment -

Update on the patch.

Show
Pankaj Doharey added a comment - Update on the patch.
Hide
Mike Fikes added a comment -

Hey Pankaj, if you look at CLJ-835, you'll see the text to the right of :hierarchy that is in your patch should be removed.

Show
Mike Fikes added a comment - Hey Pankaj, if you look at CLJ-835, you'll see the text to the right of :hierarchy that is in your patch should be removed.
Hide
Pankaj Doharey added a comment -

Yes will remove it.

Show
Pankaj Doharey added a comment - Yes will remove it.
Hide
Pankaj Doharey added a comment -

Updates docs string and removes incorrect :hierarchy text.

Show
Pankaj Doharey added a comment - Updates docs string and removes incorrect :hierarchy text.
Hide
Mike Fikes added a comment -

CLJS-2735-3.patch LGTM

Show
Mike Fikes added a comment - CLJS-2735-3.patch LGTM

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated: