Completed
Details
Assignee
Mike Fikes
Mike FikesReporter
Mike Fikes
Mike FikesApproval
Accepted
Patch
Code and Test
Affects versions
Priority
Created June 27, 2018 at 10:51 PM
Updated December 2, 2018 at 2:41 PM
Resolved December 2, 2018 at 2:41 PM
For persistent objects, if meta is identical,
with-meta
should return the identical object rather than replacing meta and returning a new object.Like https://clojure.atlassian.net/browse/CLJ-2362#icft=CLJ-2362 but for ClojureScript.
For example,
now evaluates to
true
in Clojure 1.10.0-alpha5.I suspect this can be achieved by updating all of pertinent
IWithMeta
implementations incljs.core
to be like the following revision forPersistentVector
while also dealing with the trick that
vec
andset
employ when usingwith-meta
to force a new object to be created (see CLJS-2442).