ClojureScript

Fix JS/ES6 modules requiring index.js files without filename

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

https://unpkg.com/@material-ui/core@1.4.0/index.es.js
https://unpkg.com/@material-ui/core@1.4.0/colors/index.js

import * as colors from './colors';
export { colors };

results in index.es.js requiring Closure module module$fullpath$material_ui$node_modules$$material_ui$core$colors but we currently only add provide entry ending in $index. I think we should emit provide entries both ending in index and one without.

Activity

Juho Teperi made changes -
Field Original Value New Value
Attachment CLJS-2836.patch [ 18322 ]
Juho Teperi made changes -
Description https://unpkg.com/@material-ui/core@1.4.0/index.es.js
https://unpkg.com/@material-ui/core@1.4.0/colors/index.js

{{code}}
import * as colors from './colors';
export { colors };
{{code}}

results in index.es.js requiring Closure module {module$fullpath$material_ui$node_modules$$material_ui$core$colors} but we currently only add provide entry ending in {$index}. I think we should emit provide entries both ending in index and one without.
https://unpkg.com/@material-ui/core@1.4.0/index.es.js
https://unpkg.com/@material-ui/core@1.4.0/colors/index.js

{code}
import * as colors from './colors';
export { colors };
{code}

results in index.es.js requiring Closure module {{module$fullpath$material_ui$node_modules$$material_ui$core$colors}} but we currently only add provide entry ending in {{$index}}. I think we should emit provide entries both ending in index and one without.
Juho Teperi made changes -
Attachment CLJS-2836.patch [ 18322 ]
Hide
Juho Teperi added a comment -

I have a patch mostly ready but I need to update few test cases.

Show
Juho Teperi added a comment - I have a patch mostly ready but I need to update few test cases.
Juho Teperi made changes -
Assignee Juho Teperi [ deraen ]

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated: