ClojureScript

Support webpack node lib replacements

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    {:deps {org.clojure/clojurescript {:mvn/version "1.10.339"}}}

Description

$ clj -m cljs.main -co '{:npm-deps {"readable-stream" "2.3.6"} :install-deps true}' -r
ClojureScript 1.10.339
cljs.user=> (require 'readable-stream)
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: module not found: "util" from file /private/tmp/node_modules/readable-stream/lib/_stream_readable.js
    at onresolve (/private/tmp/node_modules/@cljs-oss/module-deps/index.js:181:30)
    at onResolve (/private/tmp/node_modules/enhanced-resolve/lib/Resolver.js:70:11)
    at innerCallback (/private/tmp/node_modules/enhanced-resolve/lib/Resolver.js:143:22)
    at callbackWrapper (/private/tmp/node_modules/enhanced-resolve/lib/createInnerCallback.js:10:21)
    at next (/private/tmp/node_modules/tapable/lib/Tapable.js:249:35)
    at innerCallback (/private/tmp/node_modules/enhanced-resolve/lib/Resolver.js:143:22)
    at callbackWrapper (/private/tmp/node_modules/enhanced-resolve/lib/createInnerCallback.js:10:21)
    at next (/private/tmp/node_modules/tapable/lib/Tapable.js:249:35)
    at resolver.doResolve.createInnerCallback (/private/tmp/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:41:24)
    at callbackWrapper (/private/tmp/node_modules/enhanced-resolve/lib/createInnerCallback.js:10:21)

Error: goog.require could not find: readable_stream
	 (goog/base.js:711:20)
	 require (clojure/browser/repl.cljs:226:33)
cljs.user=>

Evidently related to https://github.com/webpack/node-libs-browser

Activity

Hide
Mike Fikes added a comment -

I wonder if this is a matter of getting Closure's support for Webpack to work for this case. (https://github.com/google/closure-compiler/commit/d0867871bbcbba44eedcb94ed2fbdab661067f42)

Show
Mike Fikes added a comment - I wonder if this is a matter of getting Closure's support for Webpack to work for this case. (https://github.com/google/closure-compiler/commit/d0867871bbcbba44eedcb94ed2fbdab661067f42)

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated: