Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Unify namespace for interacting with clojure.test.check

Description

Clojure uses the namespace clojure.spec.test.check to pass options to clojure.test.check. ClojureScript's version of spec could to the same. Also this namespace occurs in the return value of clojure.spec.test.alpha/check and it would have to be unified there.

CLJS-2964 provides a patch that already does this.

Environment

None

Activity

Mike Fikes 
January 3, 2019 at 5:40 PM

Michiel Borkent 
January 2, 2019 at 10:36 PM

Fixed in CLJS-2964

Michiel Borkent 
November 7, 2018 at 4:21 PM

This issue is fixed in CLJS-2964.

Mike Fikes 
October 31, 2018 at 1:58 AM

My guess at the history here:

Clojure introduced an stc alias meant to cover things relevant to clojure.spec.test's use of clojure.test.check: https://github.com/clojure/spec.alpha/commit/dce51cbf7720627d079eac99685ac0388b5e936e

But, ClojureScript, which doesn't have ns-indepdendent aliases, inadvertently aliased stc to clojure.test.check.

The implication for the docstring was later discovered and fixed https://github.com/clojure/clojurescript/commit/f2ebdd3ff09752d8c6afdb6b0c1f37459b536512

Further speculation:

You can see that stc was really meant to be a shorthand for spec test check. You could probably also argue that it should have really aliased cljs.spec.test.check in ClojureScript.

Duplicate

Details

Assignee

Reporter

Priority

Created October 31, 2018 at 12:17 AM
Updated January 3, 2019 at 5:40 PM
Resolved January 3, 2019 at 5:40 PM