Source maps generation local names regression introduced in CLJS-2257

Description

introduced a bug and local names are not properly generated in source maps.

Repro:

src/repro/core.cljs

With a {{diff} you can see that "x" and "y" are missing in the bad case.

This affects Chrome DevTools (and Dirac). Names in source maps are used for mapping generated names back to original names during debugging, etc. See https://github.com/binaryage/dirac/issues/53.

Environment

None

Attachments

Activity

Antonin Hildebrand
November 29, 2018 at 4:30 PM

I confirm this fixed the issue on my side.

Thanks everyone for such fast resolution!

Mike Fikes
November 29, 2018 at 1:04 PM

fixed https://github.com/clojure/clojurescript/commit/0be62b2eef8e1c70711b16aee128d5def1cf6028

Mike Fikes
November 29, 2018 at 1:01 PM

CLJS-2993.patch passes in CI and Canary

David Nolen
November 29, 2018 at 11:32 AM

Thanks Thomas!

Thomas Heller
November 29, 2018 at 9:57 AM

Source map generation was just missing the :binding op. Attached patch adds it and seems to fix the problem.

https://github.com/clojure/clojurescript/commit/6cbd40f865132b8b13c6b902b715aed43e64f0b1#diff-55b85385d2d0bfb6dc20d59ed982d5c8R189

Resize issue view side panel

Completed

Details

Assignee

Mike Fikes

Reporter

Antonin Hildebrand

Approval

Accepted

Priority

Minor

Created November 28, 2018 at 2:04 PM

Updated November 29, 2018 at 4:30 PM

Resolved November 29, 2018 at 4:30 PM