ClojureScript

chunked-seq? docstring needs correction

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: 1.10.238
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    anything, not relevant here
  • Patch:
    Code
  • Approval:
    Accepted

Description

Hi.
core.cljs contains the following piece of code:

(defn ^boolean chunked-seq?
"Return true if x is satisfies IChunkedSeq."
[x] (implements? IChunkedSeq x))

The "if x is satisfies" part hurts my eyes. How about deleting is here?
Thank you.

Activity

Hide
Mike Fikes added a comment -

LGTM

Show
Mike Fikes added a comment - LGTM
Hide
Mike Fikes added a comment -

0001-CLJS-3061-Fix-docstring-for-chunked-seq.patch does not apply on master

Show
Mike Fikes added a comment - 0001-CLJS-3061-Fix-docstring-for-chunked-seq.patch does not apply on master
Hide
Erik Assum added a comment -

New patch uploaded. Sorry about the screw up.

Show
Erik Assum added a comment - New patch uploaded. Sorry about the screw up.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: