ClojureScript

cljs.core/format

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Declined
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Implement cljs.core/format. Make sure there is nothing in gclosure for this. I suppose we should try to emulate the jvm version as much as that makes sense?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michał Marczyk added a comment -

GClosure does actually include a string formatter – goog.string.format. Note that that's both a non-ctor function name and the GClosure "namespace" name, so in order to use it one must require goog.string.format on top of gstring and say gstring/format (or perhaps leave out the gstring require spec and use goog.string/format – not tested, but should work).

The patch to introduce format and printf as wrappers for goog.string.format is naturally extremely simple, so here it is. Note that this particular patch must be applied on top of CLJS-328.

I have no idea how goog.string.format compares to the JVM's String/format (basic number formatting seems to work as it should in sprintf-like functions, but other than that I haven't tested it much).

Show
Michał Marczyk added a comment - GClosure does actually include a string formatter – goog.string.format. Note that that's both a non-ctor function name and the GClosure "namespace" name, so in order to use it one must require goog.string.format on top of gstring and say gstring/format (or perhaps leave out the gstring require spec and use goog.string/format – not tested, but should work). The patch to introduce format and printf as wrappers for goog.string.format is naturally extremely simple, so here it is. Note that this particular patch must be applied on top of CLJS-328. I have no idea how goog.string.format compares to the JVM's String/format (basic number formatting seems to work as it should in sprintf-like functions, but other than that I haven't tested it much).
Michał Marczyk made changes -
Field Original Value New Value
Attachment 0001-CLJS-324-implement-cljs.core-format-as-wrapper-for-g.patch [ 11350 ]
Hide
Permalink
David Nolen added a comment -

The tests fail for me with this patch applied.

Show
David Nolen added a comment - The tests fail for me with this patch applied.
David Nolen made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Completed [ 1 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
Permalink
David Nolen added a comment -

Backing this one out, goog.string.format defies advanced optimization and it provides few of the capabilities of Clojure's format - which does a lot because of java.util.Formatter. Apologies for the churn, but this is a simple thing for people to stub in themselves for the little bit of functionality it actually delivers.

Show
David Nolen added a comment - Backing this one out, goog.string.format defies advanced optimization and it provides few of the capabilities of Clojure's format - which does a lot because of java.util.Formatter. Apologies for the churn, but this is a simple thing for people to stub in themselves for the little bit of functionality it actually delivers.
David Nolen made changes -
Resolution Completed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Hide
Permalink
Lars Bohl added a comment -

Uploading a slighly modified version lein-cljsbuild's "advanced" demo, to demonstrate that using goog.string.format produces a runtime error with clojurescript 0.0.1913. Run "lein ring server" and navigate to http://localhost:3000/

The code in hello.cljs shows that goog.string.toTitleCase works, but not goog.string.format.

Show
Lars Bohl added a comment - Uploading a slighly modified version lein-cljsbuild's "advanced" demo, to demonstrate that using goog.string.format produces a runtime error with clojurescript 0.0.1913. Run "lein ring server" and navigate to http://localhost:3000/ The code in hello.cljs shows that goog.string.toTitleCase works, but not goog.string.format.
Lars Bohl made changes -
Attachment goog.string.format-0.0-1913.tgz [ 12318 ]
Hide
Permalink
Julien Eluard added a comment -

It looks like you are not requiring correctly format. See a working example here.

Show
Julien Eluard added a comment - It looks like you are not requiring correctly format. See a working example here.
Hide
Permalink
Lars Bohl added a comment -

Julent, thanks! It needs another [goog.string.format] after [goog.string :as gstring] before you can use gstring/format. hello.cljs now looks like this, and throws no exceptions: https://www.refheap.com/19693

Show
Lars Bohl added a comment - Julent, thanks! It needs another [goog.string.format] after [goog.string :as gstring] before you can use gstring/format. hello.cljs now looks like this, and throws no exceptions: https://www.refheap.com/19693
David Nolen made changes -
Priority Major [ 3 ] Minor [ 4 ]
David Nolen made changes -
Priority Minor [ 4 ] Trivial [ 5 ]
Hide
Permalink
Ikuru Kanuma added a comment - - edited

Would much appreciate a DCE compliant implementation of this, as I happen to be maintaining a library that broke because of this removal.
Has anyone worked on this since?

Show
Ikuru Kanuma added a comment - - edited Would much appreciate a DCE compliant implementation of this, as I happen to be maintaining a library that broke because of this removal. Has anyone worked on this since?
Hide
Permalink
Gary Fredericks added a comment -

I thought about trying to port java.util.Formatter just for fun.

I can't figure out what you mean by "DCE compliant".

Show
Gary Fredericks added a comment - I thought about trying to port java.util.Formatter just for fun. I can't figure out what you mean by "DCE compliant".
Hide
Permalink
Ikuru Kanuma added a comment -

Oh, DCE = dead code elimination.
I thought it was a common abbrev. from this mail:
https://groups.google.com/forum/#!topic/clojure-dev/URrnaU6KWQk

I would definitely send my cheers if you do decide to put in the time!

Show
Ikuru Kanuma added a comment - Oh, DCE = dead code elimination. I thought it was a common abbrev. from this mail: https://groups.google.com/forum/#!topic/clojure-dev/URrnaU6KWQk I would definitely send my cheers if you do decide to put in the time!
Hide
Permalink
David Nolen added a comment -

We are not doing this. Do not reopen.

Show
David Nolen added a comment - We are not doing this. Do not reopen.
David Nolen made changes -
Resolution Declined [ 2 ]
Status Reopened [ 4 ] Closed [ 6 ]

People

Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.