Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

memo-swap! is misnamed

Description

In order to be analogous to atoms, the current behavior of memo-swap! should be called memo-reset! since it overwrites the entire memo map. Similarly, there should be a function called memo-swap! that does an atomic swap operation on the memo cache so, for example, you can add a single value to the cache.

Environment

None

Activity

Show:

Sean Corfield April 13, 2020 at 8:08 PM

In 1.0.236

Sean Corfield November 4, 2019 at 7:50 PM

Added memo-reset! (with the behavior of the old memo-swap! and deprecated the 2-arity version of that).

Added 3+-arity of memo-swap! that actually performs the swap! on the underlying cache. This auto-wraps the result value with delay to comply with core.memoize's world view.

Sean Corfield March 1, 2018 at 8:42 AM

Good point! Backward compatibility could be maintained by checking if (map? base) – and perhaps giving a deprecation warning? – but users would have to be very careful that they would be manipulating the cache and core.memoize wraps raw values in IDeref instances so a simple


would not work – it would need to be

which would make this the only place in the API where that is really exposed.

Fixed

Details

Assignee

Reporter

Priority

Created September 23, 2013 at 11:38 PM
Updated April 13, 2020 at 8:08 PM
Resolved November 4, 2019 at 7:50 PM