core.rrb-vector

Repeated subvec and catvec fails

Details

  • Type: Defect Defect
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

The attached patch contains a test which fails for both the Clojure and ClojureScript implementations. It simply repeatedly calls subvec and catvec to assemble an interleaved vector. The patch attached contains fixes for Clojure only. I will investigate the fixes for CLJS, but thought it best to raise an issue with my findings so far.

2371 is the minimum length that exhibits the behaviour (triggers an ArrayIndexOutOfBoundsException).

Activity

Hide
Neil Kirsopp added a comment -

New patch passing tests in Clojure and ClojureScript.

Show
Neil Kirsopp added a comment - New patch passing tests in Clojure and ClojureScript.
Hide
Michał Marczyk added a comment -

Thanks so much once again! I've applied your patch to master and added a test.check-based version of your test-reduce-subvec-catvec test (keeping the original breaking example).

Show
Michał Marczyk added a comment - Thanks so much once again! I've applied your patch to master and added a test.check-based version of your test-reduce-subvec-catvec test (keeping the original breaking example).

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated: