Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Update cljs data.avl maps to return MapEntries instead of 2-elem vectors to comply with clj 1.9 and cljs 1.9.293 and later

Description

PersistentVectors in clj 1.9 are not allowed as MapEntries anymore; since cljs 1.9.229 2-elem vectors are not treated as MapEntries. However, cljs-version of data.avl map returns 2-elem vectors instead of MapEntries.

Environment

None

Attachments

1

Activity

Show:

Alex Miller June 6, 2019 at 6:05 PM

I've committed a fix for this and am in the process of releasing data.avl 0.1.0.

import March 12, 2019 at 10:26 PM

Comment made by: rnikander

Is this bug why I can't print an AVL set at the CLJS REPL?

Daniel Sutton December 4, 2018 at 4:21 PM

It is important to see the tests pass with a newer clojurescript than is in the project. No idea about the rules of bumping that in a commit but i run it locally against 1.10.339 to see it pass. Without this pass the tests fail against 1.10.339.

I also have a local path setting up this in figwheel main if there is interest.

Daniel Sutton December 4, 2018 at 2:42 PM

This patch is insufficient. The tests were passing for me because it was using an older clojurescript that implements key/value on vectors.

Fixed

Details

Assignee

Reporter

Priority

Created November 14, 2018 at 7:58 PM
Updated June 6, 2019 at 6:06 PM
Resolved June 6, 2019 at 6:06 PM