java.jdbc

Passes options all the way down in key CRUD fns

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

Specifically `insert!`, `update!`, and `delete!`.

This is terribly inconvenient to not be able to pass options down, especially when it may allow one to tune their use of the library better.

Activity

Hide
Sean Corfield added a comment -

For reference: https://github.com/clojure/java.jdbc/pull/45

Isaac, thanks for creating the JIRA issue for tracking. Do you think you'll sign the CA etc? If not, that's fine, but I won't be able to touch the patch. As noted on the PR, I'll just use the changes in the PR as a checklist of places to review in the code.

Show
Sean Corfield added a comment - For reference: https://github.com/clojure/java.jdbc/pull/45 Isaac, thanks for creating the JIRA issue for tracking. Do you think you'll sign the CA etc? If not, that's fine, but I won't be able to touch the patch. As noted on the PR, I'll just use the changes in the PR as a checklist of places to review in the code.
Hide
Isaac Sanders added a comment - - edited

I don't think I will be able to sign the CA for this contribution. I would appreciate it if you were able to review and make changes in the spirit of the PR.

– Isaac

Show
Isaac Sanders added a comment - - edited I don't think I will be able to sign the CA for this contribution. I would appreciate it if you were able to review and make changes in the spirit of the PR. – Isaac
Hide
Sean Corfield added a comment -

No problem, just wanted to check with you first, before deciding what path to take.

Show
Sean Corfield added a comment - No problem, just wanted to check with you first, before deciding what path to take.
Hide
Isaac Sanders added a comment -

Any movement on this?

Show
Isaac Sanders added a comment - Any movement on this?
Hide
Sean Corfield added a comment -

Not yet, no. As it happens I've been sick, very busy at work, and I'm traveling almost every weekend. All issues will be dealt with eventually but open source is all about volunteers giving their free time so a little patience goes a long way

Show
Sean Corfield added a comment - Not yet, no. As it happens I've been sick, very busy at work, and I'm traveling almost every weekend. All issues will be dealt with eventually but open source is all about volunteers giving their free time so a little patience goes a long way
Hide
Sean Corfield added a comment -

Will be in 0.7.0-alpha1.

Show
Sean Corfield added a comment - Will be in 0.7.0-alpha1.
Hide
Sean Corfield added a comment -

Closed by 0.7.0-alpha1 release.

Show
Sean Corfield added a comment - Closed by 0.7.0-alpha1 release.
Hide
Isaac Sanders added a comment -

Sean, apologies for seeming impatient. I hope you feel better. Thank you.

Show
Isaac Sanders added a comment - Sean, apologies for seeming impatient. I hope you feel better. Thank you.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: