java.jdbc

get-connection should prioritize its choices better

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

If you have a :datasource element, the rest should be ignored. This would allow (assoc db-spec :datasource (make-pool db-spec)) to work. Right now the presence of other things in the db-spec would override the :datasource key.

Need to review the order of clauses in get-connection to make sure that they are in a more sensible ordering. At first glance (string? db-spec) and (instance? URI db-spec) should come first, then connection, then datasource, factory, connection-uri, then others?

Activity

Hide
Sean Corfield added a comment -

0.7.0-alpha2 includes this fix.

Show
Sean Corfield added a comment - 0.7.0-alpha2 includes this fix.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: