with-db-connection cannot be safely nested

Description

It assumes there is no active connection and always closes the connection it gets. That's unsafe. It should use db-find-connection and only open/close when there isn't an active connection.

The same is true for with-db-metadata. All other uses of get-connection seem to have a db-find-connection guard.

Environment

None

Activity

Show:

Sean Corfield August 13, 2018 at 8:17 PM

Release 0.7.8 is available on Maven Central with this fix.

Sean Corfield August 11, 2018 at 4:32 AM

Will be in 0.7.8.

Completed

Details

Assignee

Reporter

Priority

Created August 11, 2018 at 1:21 AM
Updated August 13, 2018 at 8:17 PM
Resolved August 13, 2018 at 8:17 PM