Support Clojure 1.12 Array class notation refinement
Description
Per
Problem
Currently, the function clojure.tools.reader.impl.commons/parse-symbol is fairly lax with what it allows, both in general and with regard to the forthcoming Clojure 1.12 Array class notation.
Clojure 1.11 (and all previous) disallow symbols like String/1, and Clojure 1.12-alpha12 (and presumably forthcoming versions) only allows the first of the above list.
Potential Solutions
Do nothing. It’s better to be permissive and make the user check for valid symbols.
Change the clojure reader to only allow array class notation symbols.
Approach
Update clojure.tools.reader.impl.commons/parse-symbol to check symbol names for numbers, and if they exist, validate it’s only 1-9. If so, put the qualifying symbol into the ns part of the symbol and the digit into the name part.
Per
Problem
Currently, the function
clojure.tools.reader.impl.commons/parse-symbolis fairly lax with what it allows, both in general and with regard to the forthcoming Clojure 1.12 Array class notation.Clojure 1.11 (and all previous) disallow symbols like
String/1, and Clojure 1.12-alpha12 (and presumably forthcoming versions) only allows the first of the above list.Potential Solutions
Do nothing. It’s better to be permissive and make the user check for valid symbols.
Change the clojure reader to only allow array class notation symbols.
Approach
Update
clojure.tools.reader.impl.commons/parse-symbolto check symbol names for numbers, and if they exist, validate it’s only 1-9. If so, put the qualifying symbol into the ns part of the symbol and the digit into the name part.Patch
TRDR-73-4.patch
Screened by: Alex Miller