Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

deftest test-34-unify-with-metadata appears incorrect

Description

(deftest test-34-unify-with-metadata (is (run* [q] (== q (quote ^:haz-meta-daytuhs (form form form)))) '((^:haz-meta-daytuhs (form form form)))))

I am not sure what was intended for this, but replacing it with the following causes the test to fail.

(deftest test-34-unify-with-metadata (is (= (run* [q] (== q (quote ^:haz-meta-daytuhs (form form form)))) '((^:haz-meta-daytuhs (form form form))))))

I think the correct version is probably close to that, though.

Environment

None

Activity

Show:

Andy Fingerhut January 1, 2014 at 6:05 PM

As that test is written now, it is of the form:

(is (run* [q] (expr)) '(expr2))

The second argument to the macro 'is' is optional, and if present should be a string, not something like '(expr2). The test passes if (run* [q] (expr)) returns true without throwing an exception, and '(expr2) is ignored completely. That is why the test appears to be written incorrectly.

David Nolen December 31, 2013 at 1:20 AM

I'm pretty sure meta data on forms caused exceptions and that's what this test was for.

Details

Assignee

Reporter

Priority

Created December 23, 2013 at 7:10 AM
Updated January 1, 2014 at 6:05 PM

Flag notifications