Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ex* could expand macros in patterns

Description

So, tagged data structures are probably interesting in a relational context. Say you have a relation with some default logic about dogs:

Assume there's a (defmacro breed [t] `[:breed ~t]).

That's nicer than having to drop [:breed :golden-retriever] in there or whatever, since it's compile-time-checkable, less error-prone, reduces duplication, etc.

This little patch makes ex* expand macros in patterns so it doesn't treat e.g. (breed :golden-retriever) as introducing a new LVar called "breed". Test also provided.

Environment

None

Attachments

1

Activity

Show:

David Nolen March 18, 2013 at 1:05 AM

We're thinking about a more general solution here: http://github.com/clojure/core.logic/wiki/Better-syntax-support

David Nolen July 20, 2012 at 8:58 PM

I'll try to give a closer look at this issue over the weekend.

import July 20, 2012 at 4:28 PM

Comment made by: joeosborn

Nope! I actually want both. I'm doing some temporal logic stuff and I wanted some conveniences for "updating" a fluent, so I wanted to distinguish between the "key part" and the "value part" of the arguments. It looks silly for facts with no "value part", but it lets me write procedures and fns something like this:

And I write all the non-temporal fluents that way too for consistency and to help prevent mistakes.

David Nolen July 20, 2012 at 3:11 AM

What I mean is don't you want the following instead?

Note that I removed a layer of square brackets.

import July 19, 2012 at 11:57 PM

Comment made by: joeosborn

Yes, that's exactly the desired outcome in this case--a tagged value in my naive interpretation. Is the reason it fails whereas the test on :1230 doesn't the fact that it's producing a vector and not a list? Changing the fn to return a list instead of a vector didn't seem to help.

My patch, fwiw, doesn't exhibit that behavior (at least for macros, haven't tested it with fns).

Details

Assignee

Reporter

Patch

Code and Test

Priority

Created July 19, 2012 at 10:32 PM
Updated March 18, 2013 at 1:05 AM